Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

第一章几个小建议 #4

Open
freesunwaywei opened this issue May 23, 2023 · 1 comment
Open

第一章几个小建议 #4

freesunwaywei opened this issue May 23, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@freesunwaywei
Copy link

freesunwaywei commented May 23, 2023

感谢作者!刚读完第一章,几个小建议:
1、24页倒数第8行的注释貌似有点不对?模板参数是不是弄反了
2、24至25页这一段代码结束后,文字中说明最终推导出来的类型是f,而非f<>。可能是个人水平有限,确实没看懂,建议最好能稍作解释
3、35页开始走一遍完整的流程,内容都很好,但是候选函数序号原本是 1-7,排除第一个之后变成了 1-6,建议最好还是保留为 2-7,以免读者搞混

@lkimuk
Copy link
Owner

lkimuk commented Jun 9, 2023

非常感谢您的反馈!

  1. 没错,注释有误,应该是g<double, int>(Tuple<int>, double)
  2. 这里存在录入错误,注释是对的,类型为f<int>,而非f<>
  3. 接受这个建议

@lkimuk lkimuk added the good first issue Good for newcomers label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants