Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concerns about the time result in Table.2 #4

Open
Bob-Yeah opened this issue Oct 27, 2022 · 0 comments
Open

Concerns about the time result in Table.2 #4

Bob-Yeah opened this issue Oct 27, 2022 · 0 comments

Comments

@Bob-Yeah
Copy link

I'm wondering how you measure the time for EDSR and EDSR-APE?
It seems fair to me if full image forward is for EDSR and patched forward is for EDSR-APE and the time for EDSR-APE is added up with crop and combine operations. Because I'm concerned that a patched forward mode is causing extra overhead in PyTorch computation.
But in your code, if I haven't misunderstood, patched forward is both used for measuring time of EDSR and EDSR-APE.

Please check Line 123 and Line 160 in template.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant