Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue 220: This fixes the architecture of the hopfield network #222

Merged
merged 3 commits into from
Apr 12, 2020
Merged

Conversation

raimannma
Copy link
Member

Adds backward pointing connections from the output nodes to the input nodes as in #220 described.

Also renaming ALL_TO_ALL to ALL_TO_ALL_FORWARD.

Close #220

@raimannma raimannma marked this pull request as draft April 10, 2020 22:02
@raimannma
Copy link
Member Author

raimannma commented Apr 10, 2020

Architect construct can't construct a network that has connections out of the the output nodes!

  if (nodes[i].type === 'output' || (!found_output_nodes && nodes[i].outgoing.length + nodes[i].gated.length === 0)) {
    nodes[i].type = 'output';
    network.output_size++;
    outputs.push(nodes[i]);
    nodes.splice(i, 1);
  } else if (nodes[i].type === 'input' || (!found_input_nodes && !nodes[i].incoming.length)) {
    nodes[i].type = 'input';
    network.input_size++;
    inputs.push(nodes[i]);
    nodes.splice(i, 1);
  }

@raimannma raimannma marked this pull request as ready for review April 10, 2020 22:11
@christianechevarria christianechevarria merged commit e1bae89 into liquidcarrot:master Apr 12, 2020
@raimannma raimannma deleted the issue/220 branch May 15, 2020 09:28
@raimannma
Copy link
Member Author

This also Closes the architecture test for hopfield networks

Close #221

@raimannma raimannma linked an issue Aug 10, 2020 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add architecture test for Hopfield Network Is this the correct way to implement a hopfield network?
2 participants