Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen not refreshing correctly when moving addresses #197

Open
SPlanzer opened this issue Nov 9, 2016 · 1 comment
Open

Screen not refreshing correctly when moving addresses #197

SPlanzer opened this issue Nov 9, 2016 · 1 comment
Labels

Comments

@SPlanzer
Copy link

SPlanzer commented Nov 9, 2016

This is directly related to: https://github.com/linz/AIMS/issues/227 but has been opened here to give it visibility against the plugin

Intial comment below:

If you move multiple address points, it displays the 'before' and 'after' positions, 
but when you accept the  first record from the review queue, the remaining points 
appear to jump from the 'before' position to the 'after' position, 
despite not having been accepted."
@SPlanzer
Copy link
Author

SPlanzer commented Nov 9, 2016

Understood, not fixed

This bug has existed since the "move tool" sprint 6 + months ago but has just been discovered.

The move tool code must be refactored to modify the coordinates against a clone rather than the AIMS address feature being moved.

This requires a small change to the move tool code but also will require some modification to the data_managers Address.clone() method ideally by @josephramsay . Currently the clone method clones the aims feature but must be modified to go deeper and also clone the recursive objects (e.g. address position object).

This bug only has a short term visual impact to the user (i.e. no data corruption or chance of corruption) and only when a certain work flow is follow, which seems to be rear. As I understand it we are reviewing all enhancements in a few weeks and I will leave to also be prioritised then.

@SPlanzer SPlanzer added the bug label Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant