Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup changes to vellottie merge #14

Open
7 of 13 tasks
simbleau opened this issue Mar 11, 2024 · 1 comment
Open
7 of 13 tasks

Followup changes to vellottie merge #14

simbleau opened this issue Mar 11, 2024 · 1 comment
Labels
release This PR will be followed by a public release.

Comments

@simbleau
Copy link
Member

simbleau commented Mar 11, 2024

#13 is quite large already, so this track issues and further enhancements to make after its merge.

Needed for release

  • move util.rs into import.rs (from @DJMcNab)
  • add lib.rs crate documentation (from @DJMcNab)
  • reduce boilerplate in scenes/src/download/default_downloads.rs with a macro (from @DJMcNab)
  • add usage to README
  • print total file download at prompt time (from @DJMcNab)
  • Introduce a changelog

Not needed for release

@simbleau simbleau mentioned this issue Mar 22, 2024
@simbleau simbleau changed the title Followup changes to #13 Followup changes to vellottie merge Mar 22, 2024
@simbleau
Copy link
Member Author

@DJMcNab @xStrom @dfrg - I put forth a PR (#15) to get us into a release state.

The rough edges are documented. I was thinking I could defer the other changes after release.

So, I guess this is good to review, on the assumption what I've done here is enough to publish.

@simbleau simbleau added the release This PR will be followed by a public release. label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release This PR will be followed by a public release.
Projects
None yet
Development

No branches or pull requests

1 participant