Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heartbeat issue #18

Open
davidworkman9 opened this issue Oct 26, 2016 · 0 comments
Open

Heartbeat issue #18

davidworkman9 opened this issue Oct 26, 2016 · 0 comments

Comments

@davidworkman9
Copy link

davidworkman9 commented Oct 26, 2016

If a user logs in and closes the browser before the heartbeat interval has elapsed they never get a heartbeat registered and thus never get logged out. I've fixed this for now by calling heartbeat in an onLogin callback, but I'm kind of thinking this is something the package should take care of. I was also wondering if it might be better to use debounce on the event handler rather than a setInterval.

I can do a pull request when I get some spare time, just wanted to put this out there for now in case anyone else runs into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant