Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve summernote of the composer #522

Open
fabienmoyon opened this issue Jan 24, 2022 · 3 comments
Open

improve summernote of the composer #522

fabienmoyon opened this issue Jan 24, 2022 · 3 comments

Comments

@fabienmoyon
Copy link
Member

fabienmoyon commented Jan 24, 2022

Current

We are currently using the fork version v0.8.2-1 released on 21 Sep 2016 linagora/[email protected] (release) and OpenPaaS-Suite/esn-frontend-common-libs@main/package.json#L72

Expected

Upgrade to last version (currently the v.8.20) https://github.com/summernote/summernote/releases/tag/v0.8.20

With this last version, we will be able to fix some issues like #427 and also will fix many issues met by users.

Tests cases

After the upgrade we need to test many cases to be sure the last version expect that we currently have on the composer.

  1. Be able to undo by shortcut ctrl + Z
  2. Be able to copy paste images, sentences, files
  3. Be able to drag and drop images, sentences, files
  4. Copy paste a sentence must be exactly the same result from the source file and from different sources (gmail, obm, LibreOffice, onlyoffice, pad ...) :
    • Links and hyperlinks must be present
    • Bold, Italic and underline must be also the same
    • Background Color, Foreground Color also
    • Paragraph Align and justification also
    • Outdent and indent also
    • Unordered list and ordered list also
    • Line height must be the same
    • Spaces between sentences also
@alagane
Copy link
Member

alagane commented Jan 25, 2022

Cannot use v0.8.20 because of a bug fixed but not yet released: summernote/summernote#4164
But v0.8.18 is ok and fixes #515

@alagane
Copy link
Member

alagane commented Jan 27, 2022

Here is the report of tests with screenshots, against some mail web client, and summernote demo (on official website), all on Firefox
Sources are LibreOffice composer_test_page.odt and Google Document doc
summernote_tests.pdf

Also the new "link edit" feature of summernote seems a little bugged on Inbox:
image
It looks like this on summernote demo:
image

@alagane
Copy link
Member

alagane commented Jan 28, 2022

I Just noticed the demo on summernote.org is not 0.8.20 but 0.8.18, so the same version we will be using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants