Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge shell in main build? #49

Open
francisbouvier opened this issue Oct 2, 2023 · 0 comments
Open

Merge shell in main build? #49

francisbouvier opened this issue Oct 2, 2023 · 0 comments
Milestone

Comments

@francisbouvier
Copy link
Member

shell usage is for now a separate build and a separate CLI browsercore-shell.

We could merge it in the main build and use it as a optional argument, ie.

  • browsercore <arg> to launch the main server
  • browsercore --shell <arg> to launch the shell

It makes more sense as a CLI usage perspective (only 1 binary) and simplify the build process.

The only downside is that it adds linenoise as a build requirement, add therefore increase the binary size. But I don't think it's a big problem, as linenoise is meant to be small.
We can also add a build option --no-shell (non-default) to keep the option to build from sources linenoise dependancy and without shell support.

@francisbouvier francisbouvier added this to the Public Beta milestone Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant