Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netsurf: create an internal alias NodeExternal to avoid using c pointer #109

Closed
krichprollsch opened this issue Dec 5, 2023 · 1 comment · Fixed by #112
Closed

netsurf: create an internal alias NodeExternal to avoid using c pointer #109

krichprollsch opened this issue Dec 5, 2023 · 1 comment · Fixed by #112

Comments

@krichprollsch
Copy link
Member

krichprollsch commented Dec 5, 2023 •
edited
Loading

We already talked about creating an internal alias NodeExternal to avoid using c pointer. Let's do that in a separate PR.

I think once we have the NodeExternal type we can remove those comments who are not so useful.

Originally posted by @francisbouvier in #100 (comment)
@krichprollsch krichprollsch mentioned this issue Dec 5, 2023
Merged
@krichprollsch
Copy link
Member Author

Rename also toDOMNode into toNodeExternal

@krichprollsch krichprollsch mentioned this issue Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

netsurf: create alias NodeExternal lightpanda-io/browser
1 participant
@krichprollsch