Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contractcourt: properly bump justice transactions #9426

Open
morehouse opened this issue Jan 17, 2025 · 0 comments
Open

contractcourt: properly bump justice transactions #9426

morehouse opened this issue Jan 17, 2025 · 0 comments
Labels
contracts enhancement Improvements to existing features / behaviour security General label for issues/PRs related to the security of the software utxo sweeping

Comments

@morehouse
Copy link
Collaborator

Currently justice transactions use a confirmation target of 2, which should usually get them confirmed quickly. But if we get unlucky and mempool fee rates rise after we've created the justice transactions, the justice transactions can get stuck in the mempool for a long time, potentially long enough for the counterparty to claim their channel balance and escape justice.

Implementation

Ideally we'd be able to leverage the new sweeper to automatically bump fees every block. The problem is that we do need to maintain the custom logic to split the justice transaction into pinnable (i.e. HTLC claims) and non-pinnable (i.e. balance claim) groups after a few blocks delay, and we need to make sure that the non-pinnable group doesn't get any pinnable outputs from other channels grouped with it.

I think @yyforyongyu was working on "sweeper groups" at some point, which seems useful here to prevent aggregation.

@morehouse morehouse added enhancement Improvements to existing features / behaviour security General label for issues/PRs related to the security of the software contracts utxo sweeping labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts enhancement Improvements to existing features / behaviour security General label for issues/PRs related to the security of the software utxo sweeping
Projects
None yet
Development

No branches or pull requests

1 participant