Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive related to static forwarders #433

Open
jrudolph opened this issue Dec 5, 2019 · 1 comment
Open

False positive related to static forwarders #433

jrudolph opened this issue Dec 5, 2019 · 1 comment

Comments

@jrudolph
Copy link
Contributor

jrudolph commented Dec 5, 2019

We were seeing a similar issue as #388 in akka/akka#28294. When we added overloads to methods that got extra forwarders generated in previous versions compiled with a previous Scala 2.12 version, these were flagged by mima as incompatibilities:

Akka 2.5.17:

λ javap -classpath ~/.ivy2/cache/com.typesafe.akka/akka-actor_2.12/jars/akka-actor_2.12-2.5.17.jar akka.actor.CoordinatedShutdown|grep get
  public static akka.actor.CoordinatedShutdown get(akka.actor.ActorSystem);
  public static akka.actor.Extension get(akka.actor.ActorSystem);

Akka 2.5.19:

λ javap -classpath ~/.ivy2/cache/com.typesafe.akka/akka-actor_2.12/jars/akka-actor_2.12-2.5.19.jar akka.actor.CoordinatedShutdown|grep get
  public static akka.actor.CoordinatedShutdown get(akka.actor.ActorSystem);

Now we actually added another overload and got this:

λ javap -classpath akka-actor/target-java-1.8.0_232/scala-2.12/classes/  akka.actor.CoordinatedShutdown|grep get
  public static akka.actor.CoordinatedShutdown get(akka.actor.ClassicActorSystemProvider);
  public static akka.actor.CoordinatedShutdown get(akka.actor.ActorSystem);

and this mima error (against the 2.5.17 version) which doesn't make much sense:

[error]  * static method get(akka.actor.ActorSystem)akka.actor.Extension in class akka.actor.CoordinatedShutdown has a different result type in current version, where it is akka.actor.CoordinatedShutdown rather than akka.actor.Extension
@dwijnand dwijnand changed the title False positive related to static forwards False positive related to static forwarders Jan 31, 2020
@SethTisue
Copy link
Collaborator

is this just a duplicate of #388?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants