Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast Images are squished #1308

Open
HaonRekcef opened this issue Dec 25, 2024 · 8 comments
Open

Broadcast Images are squished #1308

HaonRekcef opened this issue Dec 25, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@HaonRekcef
Copy link
Contributor

What is the problem?

Broadcast images are twice as wide as they are tall, but we display them as squares in the watch tab.

Steps to reproduce the bug

  1. go to watch tab
  2. observe images

App version

0.13.12

Device Info

Additional information

No response

@HaonRekcef HaonRekcef added the bug Something isn't working label Dec 25, 2024
@veloce
Copy link
Contributor

veloce commented Dec 25, 2024

That's because of the cache size optimisation. If we remove that optimisation they are not distorted anymore. The cache size should at least respect the aspect ratio.

In any case I think they should be displayed square. I don't even care much if they are distorted since they are so small.

@HaonRekcef
Copy link
Contributor Author

I think we disagree here. I find the squares visually unappealing, especially when there is text on the images. It looks distorted and doesn't do justice to the clean design of the rest of the app.

grafik

@veloce
Copy link
Contributor

veloce commented Dec 25, 2024

Well yeah I get your point. On iOS they are much smaller that's why it doesn't bother me.

@veloce
Copy link
Contributor

veloce commented Dec 25, 2024

Screenshot_1735127204

This is how it looks like with the image not distorted. I think it is still better to have a square image here, especially on iOS where the image is so small. There's not point in seeing the whole image imo, it is too small to read the details.

@HaonRekcef
Copy link
Contributor Author

I don’t like this much either because the text gets cut off, to me this just doesn't look good. Could we slightly reduce the height and increase the width to make it twice the height instead?

@EmmetSchuler
Copy link

And maybe slightly round the edges, similar to in the broadcast list screen?

@veloce
Copy link
Contributor

veloce commented Dec 25, 2024

To me, the images are not really significant here, they are not meant to be displayed so small. The colors and shapes can be used to distinguish the broadcast though, that's why I put the thumbnails back.
If we try to keep the original aspect ratio they don't look good either, and are so small that we don't see anything.

@julien4215
Copy link
Contributor

I agree with HaonRekcef that the images should have the original aspect ratio. Even if the images are small you can clearly see that they are distorted or that the they are cut off which doesn't look good.

I cannot test how it looks on iOS but if the images are really much smaller on iOS maybe we can change the aspect ratio only for Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants