Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gap_fit does not find energies if pbc=false #607

Open
imagdau opened this issue Jul 22, 2023 · 3 comments
Open

gap_fit does not find energies if pbc=false #607

imagdau opened this issue Jul 22, 2023 · 3 comments

Comments

@imagdau
Copy link

imagdau commented Jul 22, 2023

I am trying to gap_fit on a non-periodic dataset of molecular clusters.

Isolated atom configs are not found at all if pbc=false.

When I set pbc=true and a large box just for the isolated atoms, but not for the rest of configs, only 3 energy values are reported in 'Number of target energies', however, forces are identified correctly.

Setting pbc=true for all configs and large dummy boxes fixes the issue and all energy values are found.

@imagdau
Copy link
Author

imagdau commented Jul 22, 2023

I should have mentioned that gap_fit was obtained by installing quippy-ase with pip, pythong=3.10

@bernstei
Copy link
Contributor

Is it possible that the fortran code doesn't support non-periodic cells, so we decided to filter them out? If so, I think that's a bad idea for gap_fit - it should give an error and stop.

@gabor1
Copy link
Contributor

gabor1 commented Aug 30, 2023

yes I think that's probably right, and your suggestion makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants