Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Note Duration and Rest #1

Open
garten94 opened this issue Jun 23, 2022 · 6 comments
Open

Feature Request - Note Duration and Rest #1

garten94 opened this issue Jun 23, 2022 · 6 comments

Comments

@garten94
Copy link

Hi,

I recently found your plugins and am using it quite often.

I think it is extremely useful when I am learning some licks or practicing scales (chords) in 12 keys.

I just wonder if there is any plan to add options for changing the duration of notes and for rests.

Below is just my simple idea for UI:
UI_suggested

And Result:
Result_suggested

Although it would be even better if triplet (or polyrhythm...) is possible, I think it is not an easy job.

Anyway, thanks for great plugin.

@lgvr123
Copy link
Owner

lgvr123 commented Jun 23, 2022

It's quite a nice idea, and you already made most difficult part of it: the UX design ! It shouldn't be complicated to implement. Keep watching the repository. I should have some time in the coming weeks to implement it.

@garten94
Copy link
Author

Great! I will be waiting for it. Thanks!!

@lgvr123
Copy link
Owner

lgvr123 commented Jul 4, 2022

I pushed a new release. Still in test phase, but it should not contain any major issue.
I should add a way maybe to save the rhythm patterns.
https://github.com/lgvr123/musescore-workoutbuilder/releases/tag/2.4.0_alpha1

@lgvr123 lgvr123 reopened this Jul 4, 2022
@garten94
Copy link
Author

garten94 commented Jul 7, 2022

Thanks for reminding me.
I tested a bit and found no problem at the moment.
(R) is Rest, not Root
When I first saw (R), I thought it stood for 'Root' note. Though I soon realized it was 'Rest'.

Whole note symbol

Although I don't mind it much (and idk if this is just my issue), but it seems that whole note symbol is not working properly in my environment. FYI, I'm using Musescore 3.6.2 (macOS Monterey ver.12.4)

@garten94
Copy link
Author

garten94 commented Jul 7, 2022

AND... my last (Hopefully.. lol) feature request.. is 'triplet'.
As you may know, jazz licks commonly contain triplet. So, it would be nice to add it...
Again, below is my suggested UI:
(it is just my idea for not modifying UI as possible, it's surely welcome to change the concept thoroughly)
Triplet Added UI

When triplet is selected, the rhythm order changes:
(1-2-3-4-5-6-7-8-9-10-12) --> (1-2-2-2-3-4-5-6-7-8-9-10)
Triplet Selected

Practice Example:
Practice Pattern

Practice Result

Thanks!

Plus, I think it would be nice if each pattern (Pattern 1 ~ Pattern 10) could have independent rhythm. Currently all 10 patterns must have the exact same rhythm.

@lgvr123
Copy link
Owner

lgvr123 commented Jul 7, 2022

Thanks for testing. I'll check for the whole symbol. For the "(R)" I tried to have a rest symbol instead of that "(R)" but couldn't manage to have a musical symbol for one entry and regular text for the other ones. So I dropped that idea.
The triplet is another nice idea but more complicated... Maybe in a next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants