Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename variables and message types #218

Open
byeonggiljun opened this issue Aug 18, 2023 · 1 comment
Open

Rename variables and message types #218

byeonggiljun opened this issue Aug 18, 2023 · 1 comment

Comments

@byeonggiljun
Copy link
Collaborator

byeonggiljun commented Aug 18, 2023 •
edited
Loading

Some variable names and message types need to be renamed.

This is a list of them.

  • TimedMessage -> TaggedMessage
  • logical time -> logical tag tag
  • LogicalTimeComplete -> LogicalTagComplete
  • TimeAdvanceGrant -> TagAdvanceGrant
  • ProvisionalTimeAdvanceGrant -> ProvisionalTagAdvanceGrant
  • FederatedApp -> Federate

Generate codes should also be modified moderately.
@lhstrh
Copy link
Member

lhstrh commented Aug 18, 2023

Actually, one should never use the term "logical tag" but just "tag" (which is equivalent to "logical time").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lhstrh @byeonggiljun