Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve snapshot test suite to cover more edge cases #42

Open
PullJosh opened this issue Mar 4, 2020 · 1 comment
Open

Improve snapshot test suite to cover more edge cases #42

PullJosh opened this issue Mar 4, 2020 · 1 comment
Assignees
Labels
testing Expanding or fixing issues in test cases

Comments

@PullJosh
Copy link
Collaborator

PullJosh commented Mar 4, 2020

Our tests just caught a bug, which is pretty neat! I'd like to reach a point where automated tests can pretty much be trusted, so that if the tests pass, the PR can be merged. To do so, we need a better corpus of wonky projects.

Fortunately, such a corpus has already been compiled for just such a situation as this!

I think it makes sense to take most of the projects in the corpus and include them as snapshot tests. (Once SB3 output lands, we can even create tests that expect any .sb3 that is inputted and then regurgitated back out to match the original exactly!)

@towerofnix towerofnix added the testing Expanding or fixing issues in test cases label Mar 11, 2023
@towerofnix towerofnix changed the title Improve test suite to cover more edge cases Improve snapshot test suite to cover more edge cases Mar 11, 2023
@towerofnix
Copy link
Member

This is a pretty big project and relevant to stuff I want to work on (improving testing in general), so I'm self-assigning for this! I've retitled the issue to address snapshot tests in particular, since we may want to implement unit tests later, which are an entirely separate thing to track.

@towerofnix towerofnix self-assigned this Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Expanding or fixing issues in test cases
Projects
None yet
Development

No branches or pull requests

2 participants