Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark_entry_as_read(entry, read: bool = True) #256

Closed
lemon24 opened this issue Oct 5, 2021 · 0 comments
Closed

mark_entry_as_read(entry, read: bool = True) #256

lemon24 opened this issue Oct 5, 2021 · 0 comments

Comments

@lemon24
Copy link
Owner

lemon24 commented Oct 5, 2021

(found during #254 (comment))

It would be nice to allow users like the entry_dedupe plugin to call mark_entry_as_read(entry, read=read) instead of having to call mark_entry_as_read() or mark_entry_as_unread() depending on the variable.

We can keep mark_as_unread() as an alias to mark_entry_as_read(..., read=False).

That said, if Storage.mark_as_read() becomes stable, maybe we don't need to do this anymore.

@lemon24 lemon24 closed this as completed in 01f90b9 Oct 6, 2021
@lemon24 lemon24 changed the title mark_as_read(entry, read: bool = True) mark_entry_as_read(entry, read: bool = True) Oct 6, 2021
lemon24 added a commit that referenced this issue Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant