Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry parts configuration #42

Open
2 of 3 tasks
ManuelHu opened this issue Jul 1, 2024 · 1 comment
Open
2 of 3 tasks

Geometry parts configuration #42

ManuelHu opened this issue Jul 1, 2024 · 1 comment

Comments

@ManuelHu
Copy link
Collaborator

ManuelHu commented Jul 1, 2024

We will need a better way to express which parts of the geometry the tool will create. The current approach using --assemblies=strings,fibers,... is too limited.

A list of things that might need to be expressed in the new format/functionality (no particular order, certainly not exhaustive):

  • deployment of IB/OB fiber modules (all or only selected) - do we really want this, or should we use custom channelmaps?
  • Position of sources in the SIS reference system, deployment of sources
  • a timestamp to use for the channelmaps from https://github.com/legend-exp/legend-hardware-config

what will not be part of this file:

  • anything that is already present in the metadata
@ManuelHu
Copy link
Collaborator Author

ManuelHu commented Nov 28, 2024

The most important things are already implemented (i.e. the config of calibration sources), and selecting a metadata timestamp is also possible via config.

We should decide, if we want to mirror some CLI flags also to the config file (i.e. fiber model selection, detailed or segmented?)

@ManuelHu ManuelHu reopened this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant