Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove type piracy plotting recipes #51

Open
oschulz opened this issue Jul 5, 2024 · 4 comments
Open

Remove type piracy plotting recipes #51

oschulz opened this issue Jul 5, 2024 · 4 comments
Assignees
@oschulz @fhagemann
Labels
bug Something isn't working

Comments

@oschulz
Copy link
Contributor

oschulz commented Jul 5, 2024

This is type piracy and has to go:

LegendDataManagement.jl/ext/LegendDataManagementRecipesBaseExt.jl

Line 13 in 0a74d75

@recipe function f(

LegendDataManagement must not define plotting recipes for types it does not own!
@fhagemann
Copy link
Contributor

Do I need to define a new struct or type in LegendDataManagement or is it enough to "just" specify the column names of the Table using an alias?

@oschulz
Copy link
Contributor Author

oschulz commented Jul 5, 2024

It should really be a type owned by LegendDataManagement.

@fhagemann
Copy link
Contributor

@oschulz could you have a look into this and propose a good solution for this?

@theHenks theHenks added the bug Something isn't working label Sep 17, 2024
@fhagemann
Copy link
Contributor

@oschulz bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oschulz oschulz

@fhagemann fhagemann

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oschulz @fhagemann @theHenks