Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable - Confusing '1 resource selected' text when having selected a folder with resources #4650

Closed
pcenov opened this issue Aug 16, 2024 · 3 comments · Fixed by #4676
Closed

Comments

@pcenov
Copy link
Member

pcenov commented Aug 16, 2024

Observed behavior

When I select a folder with resources, in the main table I see the following text: '1 folder, N resources' which is mostly correct as clicking the 'Move', 'Copy' and 'Delete' icons will result in the change being applied to the folder and all of the resources within the folder. But if I go ahead and select one of the new editing icons such as 'Edit categories' then I see the incorrect text 1 resource selected under the title of the modal. The text is incorrect because it says 'resource' while I have selected a folder with resources. So it seems that changing it to 'N folders, N resources selected' will be a step in the right direction, however when we have nested folders with resources the text can become something like '4 folders, 15 resources' which will still be confusing. The same is valid if I've selected several folder and resources in which case currently the text is just N resources selected

Expected behavior

To be further discussed.

Steps to reproduce the issue

  1. Go to https://unstable.studio.learningequality.org/en/accounts/#/ and sign in
  2. Open a channel with folders and all of the supported resources
  3. Click the checkbox of a folder with resources and observe the '1 folder, N resources' text above the table
  4. Click the 'Edit categories' icon and observe the text '1 resource selected' in the modal

Additional information

number.of.selected.resources.mp4

Console logs

no errors observed in the console

Usage Details

@pcenov
Copy link
Member Author

pcenov commented Aug 16, 2024

@radinamatic

@akolson
Copy link
Member

akolson commented Aug 19, 2024

Tagging @jtamiace for thoughts on this. cc @marcellamaki

@marcellamaki marcellamaki self-assigned this Aug 21, 2024
@jtamiace
Copy link
Member

I think we've decided to go with a quick fix for this issue, which is to make sure that the selection text in the bulk edit modal is updated to match the selection text in the main Studio UI.

So if I've selected a folder which contains 2 resources, I should see "1 folder, 2 resources" in both locations.

For future releases, there are other ideas that we're exploring on improving the clarity of that selection statement in the Slack discussion here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants