Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Analytics #2460

Open
soyllamas opened this issue Dec 19, 2024 · 1 comment
Open

Disable Analytics #2460

soyllamas opened this issue Dec 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@soyllamas
Copy link

soyllamas commented Dec 19, 2024

Use case

The CLI currently fails to execute commands when analytics tracking calls are blocked by custom DNS configurations (e.g., DNS-level ad/tracking blockers). This makes the CLI unusable for users who implement network-level privacy controls.

image

Proposal

  1. Add a user-configurable analytics flag:
    • Allow users to disable analytics via CLI flags (e.g., patrol --disable-analytics or patrol --analytics=false).
    • This gives users explicit control over analytics collection.
  2. Implement "fire and forget" analytics:
    • Make analytics non-blocking by running it asynchronously.
    • Analytics failures won't affect command execution or user experience.
    • Main command continues regardless of analytics success/failure.
@Kendru98 Kendru98 added the bug Something isn't working label Dec 20, 2024
@pdenert
Copy link
Collaborator

pdenert commented Jan 8, 2025

Hi @soyllamas. Thanks for the issue.
Currently, at the first run, patrol asks whether you agree for analytics or not. If you don't agree, patrol won't be sending analytics.
If you agreed for analytics, but now want to disable it, you can find file $Home/.config/patrol_cli/analytics.json and change: "enabled":true to "enabled":false. Alternatively, you can delete this file and the next time you launch patrol it will ask for analytics permission again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants