Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Eliminate warnings in Rust code #41

Open
felixfaisal opened this issue Jan 5, 2022 · 7 comments
Open

[Refactor] Eliminate warnings in Rust code #41

felixfaisal opened this issue Jan 5, 2022 · 7 comments
Assignees
Labels
issue/willfix This issue will be worked on language/rust Rust related

Comments

@felixfaisal
Copy link
Contributor

Description
Currently, upon building any of the filters you get rust compilation warnings. We can eliminate these warnings and follow best practices of Rust.

Expected Behavior
Code compiles without any warnings

Screenshots
Image

To Reproduce
Steps to reproduce the behavior:

  • Compile any of the filters
@leecalcote
Copy link
Member

leecalcote commented Jan 17, 2022

Ouch. Good find. Yes. Would you like to take this on, @felixfaisal?

@felixfaisal
Copy link
Contributor Author

I'd like to take this on @leecalcote :D

@leecalcote
Copy link
Member

@felixfaisal, excellent. 😄

@Azanul

This comment was marked as spam.

@acald-creator
Copy link
Contributor

@Azanul I am but I'm still waiting on my PR to be accepted and merged.

@acald-creator acald-creator added the issue/willfix This issue will be worked on label Feb 15, 2023
@horizenight
Copy link

Hello @acald-creator @felixfaisal
Didn't any linked PRs to this issue, would like to review the PR ( if already solved ) or would like to solve it.

@felixfaisal
Copy link
Contributor Author

Hey @horizenight I think you can take it up if the following PR does not solve it already - #49 but would be great if you double check it with @acald-creator
CC: @leecalcote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/willfix This issue will be worked on language/rust Rust related
Development

No branches or pull requests

5 participants