Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Have LearningConnection as a normal Class and not as a Process #776

Open
SveaMeyer13 opened this issue Aug 21, 2023 · 0 comments
Assignees
Labels
0-needs-review For all new issues 1-feature New feature request

Comments

@SveaMeyer13
Copy link
Contributor

Issue: LearningDense and LearningSparse contain code duplicates as they primarily inherit from LearningConnectionProcess but also need the functionality of the base class of Sparse and Dense, respectively. We cannot call init() of both super classes since both of them in turn inherit from and initialize AbstractProcess, which would lead to overwritten proc_params.

Suggested Solution:
Have LearningConnection (instead of LearningConnectionProcess) as a normal Class that does not inherit from AbstractProcess. Have LearningDense/LearningSparse inherit from Sparse (primarily) and from LearningConnection.

@SveaMeyer13 SveaMeyer13 added the 1-feature New feature request label Aug 21, 2023
@SveaMeyer13 SveaMeyer13 self-assigned this Aug 21, 2023
@github-actions github-actions bot added the 0-needs-review For all new issues label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-needs-review For all new issues 1-feature New feature request
Projects
None yet
Development

No branches or pull requests

1 participant