Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process.run and Runtime.start should accept an int or None as conditions #768

Open
tim-shea opened this issue Aug 5, 2023 · 0 comments
Open
Labels
0-needs-review For all new issues 1-feature New feature request

Comments

@tim-shea
Copy link
Contributor

tim-shea commented Aug 5, 2023

User story

As a user, I want to be able to pass an int or None to the runtime.start method and process.run, rather than an AbstractRunCondition. If I pass an int, runtime.start should create a RunSteps condition with the value of the int as the number of steps. If I pass None, runtime.start should create a RunContinuous condition. This will reduce the need to import or know about the RunCondition classes for the vast majority of use cases.

Conditions of satisfaction

  • User can pass an AbstractRunCondition, int, or None for the condition parameter of Process.run
  • User can pass an AbstractRunCondition, int, or None for the condition parameter of Runtime.start
  • If the condition is an int, that will be used as the number of steps to run the process.
  • If the condition is None, the process will run with a RunContinuous condition.
@tim-shea tim-shea added the 1-feature New feature request label Aug 5, 2023
@github-actions github-actions bot added the 0-needs-review For all new issues label Aug 5, 2023
@tim-shea tim-shea linked a pull request Aug 5, 2023 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-needs-review For all new issues 1-feature New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant