Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android toolbar "link" item broken since 3.2.3 and introduction of custom toolbar #11563

Closed
dejafait opened this issue Dec 31, 2024 · 5 comments
Labels
bug It's a bug

Comments

@dejafait
Copy link

Operating system

Android

Joplin version

3.2.3

Desktop version info

No response

Current behaviour

When I click on any other item of note editing toolbar (e.g. bold, italic, bullet point) it works as expected, but nothing happens when clicking on link item.

Expected behaviour

When clicking on link item it should open a link dialog (name , url) like it used to do.

Logs

No response

@dejafait dejafait added the bug It's a bug label Dec 31, 2024
@personalizedrefrigerator
Copy link
Collaborator

Thank you for reporting this!

For me, with a build from dev, clicking the link button does open the "edit link" dialog. For comparison, here's the mobile app's version information:

Joplin Mobile 3.2.3 (dev, android)

Client ID: 593be957a15149b8bfead0267a2e18c0
Sync Version: 3
Profile Version: 47
Keychain Supported: No

Revision: 2b43a9a4d

Android API level: 33
WebView version: 131.0.6778.136
WebView package: com.google.android.webview
FTS enabled: 1
Hermes enabled: 1

Follow-up questions:

  • Does the "edit link" button work in a new, otherwise empty note?
  • If plugin support is enabled, does disabling plugin support help?
    • Plugin support can be enabled/disabled from configuration > plugins > advanced.

@dejafait
Copy link
Author

dejafait commented Jan 3, 2025

Answering your follow up questions: the issue persists in a blank new note and after disabling plugin support and restarting the app.

I also tried resetting the toolbar layout, it did not help.

I noticed the search icon has the same issue, so it's not just the link icon.

@dejafait
Copy link
Author

dejafait commented Jan 3, 2025

Fyi

Joplin Mobile 3.2.3 (prod, android)

Client ID: a2c47c2b06a349a9a6f2a3c8067f84be
Sync Version: 3
Profile Version: 47
Keychain Supported: No

Revision: 33942d44c (dev)

Automatic Backlinks to note: 3.0.3
Embed Search: 2.0.0
Quick Links: 1.3.2

Android API level: 30
WebView version: 131.0.6778.135
WebView package: com.google.android.webview
FTS enabled: 1
Hermes enabled: 1

@personalizedrefrigerator
Copy link
Collaborator

This should be fixed in Joplin for Android v3.2.4.

Possible cause: The toolbar update made changes in both packages/app-mobile and packages/editor. If the old version of code from packages/editor was still in use (e.g. due to only rebuilding packages/app-mobile), then some functionality (e.g. search) wouldn't work.

@dejafait
Copy link
Author

Fixed as of 3.2.7 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug
Projects
None yet
Development

No branches or pull requests

2 participants