Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for fractions broke when static dictionary was removed #2

Open
lassevk opened this issue Feb 18, 2020 · 0 comments
Open

Support for fractions broke when static dictionary was removed #2

lassevk opened this issue Feb 18, 2020 · 0 comments
Assignees
@lassevk
Labels
bug Something isn't working

Comments

@lassevk
Copy link
Owner

lassevk commented Feb 18, 2020

Some of the characters supposed to be handled by this library is not correctly counted as numerical and thus breaks comparison.

In particular, fraction characters are counted as text.

This worked before, when the static dictionary was part, which was removed in favor for the slightly faster call to Char.GetNumericValue, but which does not support all those characters.
@lassevk lassevk self-assigned this Feb 18, 2020
@lassevk lassevk added the bug Something isn't working label Feb 18, 2020
lassevk added a commit that referenced this issue Feb 24, 2020
@lassevk
Fix issue #2, reintroduce static lookup table for numerical characters
3f9a3bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lassevk lassevk

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lassevk