Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No errors on mac but there are errors on ubuntu #333

Open
AchrafBardan opened this issue Jan 15, 2025 · 2 comments
Open

No errors on mac but there are errors on ubuntu #333

AchrafBardan opened this issue Jan 15, 2025 · 2 comments

Comments

@AchrafBardan
Copy link

Pint Version

2.10.0

PHP Version

8.4

Description

Macos php: 8.4.2
Docker ubuntu php: 8.4.1

When i run pint on macos there are no errors but when i ran it on github actions there was an error. class_attributes_separation

It changed one thing:

Image

pint.json

Steps To Reproduce

  1. run pint on mac with php 8.4.2 on a class with an @use doc above a traits
  2. run pint on ubuntu with php 8.4.1 on a class with an @use doc above a traits
Copy link

Thank you for reporting this issue!

As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.

If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.

Thank you!

@ricdizio
Copy link

make sure the pint.json file you are using in you github actions is the same you are using to run pint in your local. Also, pipeline should not do any changes to your code, it should only validate your project code style for each PHP file.

for running pint to check coding style without modifying the files make sure you add the flag --test in your pipeline or github actions.

/vendor/bin/pint --test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants