You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Oi,
thanks for porting Cannonball to C !
I did notice an issue with it though. When you start the game and let the demo play for a while, it should normally display the highscore leaderboards. Instead, it freezes.
What happens is that it becomes stuck in a loop. https://github.com/lantus/Cannonball-C/blob/master/src/main/engine/audio/osound.c#L473
The problem is that chan_ram is 0x800 in size and uint8_t is not big enough for the for loop to clear its memory so it promptly becomes stuck. Original source code was using uint16_t here, not sure why you decided to use an uint8_t here.
Switch it to uint16_t and the leaderboard appears like normal.
Not sure if this happens on a real Amiga but it definitely happens on a PC.
The text was updated successfully, but these errors were encountered:
Oi,
thanks for porting Cannonball to C !
I did notice an issue with it though. When you start the game and let the demo play for a while, it should normally display the highscore leaderboards. Instead, it freezes.
What happens is that it becomes stuck in a loop.
https://github.com/lantus/Cannonball-C/blob/master/src/main/engine/audio/osound.c#L473
The problem is that chan_ram is 0x800 in size and uint8_t is not big enough for the for loop to clear its memory so it promptly becomes stuck. Original source code was using uint16_t here, not sure why you decided to use an uint8_t here.
Switch it to uint16_t and the leaderboard appears like normal.
Not sure if this happens on a real Amiga but it definitely happens on a PC.
The text was updated successfully, but these errors were encountered: