Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref_storage #234

Open
rb004f opened this issue Aug 6, 2021 · 1 comment
Open

ref_storage #234

rb004f opened this issue Aug 6, 2021 · 1 comment

Comments

@rb004f
Copy link
Collaborator

rb004f commented Aug 6, 2021

in ref_storage, we have an equivalence between pressure and density, e.g., storage["reservoir_density_max"] = storage["reservoir_p_max"]. Shouldn't there be a conversion factor here?

@kaarthiksundar
Copy link
Collaborator

This is correct from the perspective of transient. The non-dimensionalization for all transient formulations is performed so that the non-dimensional pressure == non-dimensional density. If we use a different non-dimensionalization (say if we start with flow scaling, like some instances do), then this is incorrect. Will have to see how this can be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants