Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode per-unit indicator as true/false instead of 1/0 #221

Open
tasseff opened this issue Oct 21, 2020 · 4 comments
Open

Encode per-unit indicator as true/false instead of 1/0 #221

tasseff opened this issue Oct 21, 2020 · 4 comments

Comments

@tasseff
Copy link
Member

tasseff commented Oct 21, 2020

No description provided.

@rb004f
Copy link
Collaborator

rb004f commented Oct 21, 2020

This will make GasModels consistent with the conventions of PowerModels

@tasseff
Copy link
Member Author

tasseff commented Oct 21, 2020

Additionally, for greater consistency, the field should be called per_unit instead of is_per_unit.

@ccoffrin
Copy link
Member

The key per_unit is a standard https://lanl-ansi.github.io/InfrastructureModels.jl/stable/developer/ it should not be changed unless done in other packages as well.

@rb004f
Copy link
Collaborator

rb004f commented Oct 22, 2020

Correct, this issue is to make GasModels consistent with the other packages. Rename is_per_unit to per_unit and make it a boolean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tasseff @ccoffrin @rb004f