-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tracking run inputs #98
Comments
The problem is that reticulate isn't used for If reticulate was used, this would all be resolved. Hence, the fix should be using reticulate for these two methods and it's going to work. |
I think we should have a discussion about whether it is worth using the API at all. We have about reached the limit of what the API can do currently and if we have to use {reticulate} for some things anyway, maybe it's better to use it for everything? It would mean a fairly big refactor but after that development might be quicker. |
Yes, we should have that discussion next week or so, I agree. But what's indeed much better with the API is that you're not relying on 20 Python packages that Django needs to map all the schema modules. So, it's not a clear decision pro reticulate for querying say bionty. That's likely more elegant through the REST API. |
Under the hood of def load():
uid = from REST
artifact = ln.Artifact.get(uid)
return artifact.load() |
Solution 1
Solution 2
Solution 3
|
I'm strongly favoring Solution 2 for the up-coming weeks. |
I'll have a look this morning. There are other things I would like to improve but this one we haven't looked at yet so I'll do it first. |
We observed that when data from any non-default instance such as cellxgene is used as input during a
Run
, it does not show up in the linage graph.@lazappi had suggested that this is probably because of our usage of the API to get the data and not the Python code which probably does more magic.
The text was updated successfully, but these errors were encountered: