Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Records container class #59

Merged
merged 21 commits into from
Oct 30, 2024
Merged

Add Records container class #59

merged 21 commits into from
Oct 30, 2024

Conversation

lazappi
Copy link
Collaborator

@lazappi lazappi commented Oct 24, 2024

Adds a class for managing multiple records. I called it RelatedRecords because that's what it's used for and that is closer to the Python object.

Fixes #48

@lazappi
Copy link
Collaborator Author

lazappi commented Oct 24, 2024

Work in progress. Requires features from #54 so waiting for that to be merged first.

@lazappi lazappi marked this pull request as ready for review October 28, 2024 09:07
@lazappi lazappi requested a review from rcannood October 28, 2024 09:07
rcannood
rcannood reviewed Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@rcannood rcannood left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! The general approach looks great to me.

I left a few questions / suggestions in comments. In addition:

  • Could you update architecture.qmd to add the $df() methods and the relatedrecords class?

R/RelatedRecords.R Show resolved Hide resolved
R/RelatedRecords.R Outdated Show resolved Hide resolved
R/Record.R Show resolved Hide resolved
@lazappi lazappi requested a review from rcannood October 30, 2024 10:35
rcannood
rcannood approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Luke!

@rcannood rcannood merged commit d3e0e8b into main Oct 30, 2024
7 checks passed
@rcannood rcannood deleted the issue-48/add-RecordsList branch October 30, 2024 10:39
lazappi added a commit that referenced this pull request Oct 31, 2024
@lazappi
Merge remote-tracking branch 'origin/main' into issue-49/adjust-print…
c392824 
…-colours

* origin/main:
  Add Records container class (#59)
  Refactor documentation (#67)
  Fix macOS runner (#66)
  Add check_requires() function and update installation docs (#56)
  Remove link tables from print output (#55)
  Add progress bar (#58)
  Add get_records() to API and df() to Registry (#54)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcannood rcannood rcannood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a RecordsList class?
2 participants
@lazappi @rcannood