-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pkgdown docs #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcannood
changed the base branch from
fix-unexpected-fields-in-settings
to
main
October 4, 2024 15:29
Took me too long to figure out that the issue in rendering the vignettes was not due to quarto, but due to the package not having access to any login credentials to work with. I simply removed the vignette for now, and will add it back in a separate PR. |
Merged
lazappi
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🎉!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MINOR CHANGES
Do not complain when foreign keys are not found in a record, but also do not complain when they are (PR Create pkgdown docs #13).
Further simplify the
README
, and move the detailed usage description to a separate vignette (PR Create pkgdown docs #13).Add a
pkgdown
website to the project (PR Create pkgdown docs #13).Generate vignettes using Quarto (PR Create pkgdown docs #13).