-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix CI setup #125
🐛 Fix CI setup #125
Conversation
If this resolves things, it'd be great to merge ASAP. |
Ah, but looking at it it appears like the CI would be inconsistent with what the user reads. So, this seems dangerous. |
The package should work just with lamindb installed, without need of bionty or wetlab. Something very recent must have introduced these warnings and it's a shame that we didn't catch them. If In retrospect, I should have kept digging about the below this morning: While having lamindb not be discovered by reticulate is possible, I'm now pretty convinced it opens up a dangerous edge-case mode for using the package that then needs to be tested in addition to "conventional usage", which heavily relies on reticulate and lamindb. Also looping in @lazappi into the discussion. |
I think the pkgdown CI should install these packages to trigger the least amount of warnings. The unit test CI on the other hand should be able to work without bionty and wetlab.
The warning related to bionty and wetlab not being installed are coming from python, though. The other one about reticulate not being able to import lamindb via reticulate is one I wasn't able to replicate locally so far. I was trying to reproduce it via this PR. |
I think I disagree. If the docs don't show warnings and users see them they'll be worried and confused. I'd rather say: "it's Ok to ignore these warnings; they're only relevant if you use the Python package". Background: I was planning on removing the warnings about bionty & wetlab on the
These warnings have always been there and make sense if you continue to use lamindb as a Python package after connecting via the CLI.
This is what I'm talking about! This is a new thing and looks worrisome to me. |
{reticulate} being able to find the correct Python installation is one of the trickier things about using it. If you have everything installed in whatever your base system Python is then it should be fine but if lamindb is installed in a I have lamindb only in an environment so it won't be found unless I use This is one of the reasons I think we should discuss switching fully to {reticulate} and dropping the API access, so we can make Python availability a hard dependency. |
I also learned this playing with
Understood. I'm also pretty convinced that this is how it should be done independent of that reason: there is too much logic in |
Turns out the reticulate/Python setup was a red herring. Apparently calling This PR adds a temporary workaround to make sure IPython is installed and also created laminlabs/laminhub-public#29. |
Customers are looking at it right now, so I'll merge it. |
If changes need to be made, they can go in another PR! |
Thanks for quick resolution, Robrecht! |
Related to: laminlabs/laminhub-public#29
Description
reticulate::import("lamindb")
fails slightly more user friendly by instructing the user to also runreticulate::py_last_error()
.Checklist
Before review
Before merge
README
CHANGELOG