Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

➖ Eliminate dependency on anndata? #2314

Open
falexwolf opened this issue Jan 2, 2025 · 4 comments
Open

➖ Eliminate dependency on anndata? #2314

falexwolf opened this issue Jan 2, 2025 · 4 comments
Assignees
@Koncopd

Comments

@falexwolf
Copy link
Member

falexwolf commented Jan 2, 2025 •
edited
Loading

Given we're not depending on zarr, spatidaldata, tiledbsoma, etc. -- can we also not depend on anndata?

I'm just getting a scipy install error.

  help: `scipy` (v1.6.1) was included because `lamindb` (v0.78a1) depends on
        `anndata` (v0.10.5.post1) which depends on `scipy`
@falexwolf
Copy link
Member Author

Will also help speed up imports :)

@Koncopd
Copy link
Member

Koncopd commented Jan 2, 2025 •
edited
Loading

I am pretty sure this is a problem of the uv resolver, not lamindb. lamindb of course doesn't depend on anndata v0.10.5.post1. Nothing to fix here in lamindb.

@falexwolf falexwolf changed the title Eliminate dependency on anndata? ➖ Eliminate dependency on anndata? Jan 2, 2025
@falexwolf
Copy link
Member Author

Yeah, I'm also confident that this is a uv problem. I'm asking whether we can generally eliminate anndata as a hard dependency.

@Koncopd
Copy link
Member

Koncopd commented Jan 2, 2025

I think it is integrated too tightly, but i will check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Koncopd Koncopd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Koncopd @falexwolf