Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Unique contraint on name field of most registries #2269

Open
falexwolf opened this issue Dec 10, 2024 · 2 comments
Open

🚸 Unique contraint on name field of most registries #2269

falexwolf opened this issue Dec 10, 2024 · 2 comments
Assignees

Comments

@falexwolf
Copy link
Member

falexwolf commented Dec 10, 2024

The Feature and ULabel registries have a unique constraint on the name field:

Let's review all other label registries towards whether they also have it.

Note: It's important to note that versioned entities shouldn't have that unique constraint because multiple versions of the same entity should be able to have the same name; e.g. Transform and Collection.

Internal Slack ref.

@falexwolf
Copy link
Member Author

Indicating this in the docs:

@Zethson
Copy link
Member

Zethson commented Dec 10, 2024

I looked at wetlab. It has:

  1. Compound: We're using the Drug ontology for it. Tricky with different Source.
  2. Experiment: I think you can have the same experiment with different dates. Not sure whether we should make name unique here.
  3. Well: IDEK whether they need a name in the first place but it should be okay here. If anything, row and column should be (jointly)? unique here.
  4. PerturbationTarget: Guess it's okay to have unique name.
  5. GeneticPerturbation: You can target the same genes with different CRISPR sequences. Users would therefore potentially be forced to encode the sequences in the name which is bad. Not sure.
  6. CompoundPerturbation: Same compound name with different concentrations surely happens in experimental setups. Learning more towards a "no".
  7. EnvironmentalPerturbation: Same argument. You can use different temperatures etc. "no".
  8. CombinationPerturbation: Technically hidden concentrations but w/e.
  9. BioSample: Can have different batches and we might need to encode the batches in the name then. But okay I guess.
  10. TechSample: Different batches but okay.
  11. Donor: No. Names cannot be unique.

My conclusion is that while we could do it, it's always going to be a case by case decision and there's quite some grey area. I fear that this would lead to inconsistencies and unexpected behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants