Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .from_values from Feature #2249

Open
Zethson opened this issue Dec 3, 2024 · 1 comment
Open

Remove .from_values from Feature #2249

Zethson opened this issue Dec 3, 2024 · 1 comment
Assignees
Labels

Comments

@Zethson
Copy link
Member

Zethson commented Dec 3, 2024

Add a description

https://laminlabs.slack.com/archives/C07DB677JF6/p1733229346107939

It is not possible so it should not be in the API let alone in the example section of the docstring (I removed it).

@falexwolf
Copy link
Member

Alternative is to re-enable the default values that were possible in from_values(). When we still had them, this was valid.

Problem is that from_values() is part of CanCurate which dictates most of the Feature API; so, it's not 100% straightforward to remove it.

Maybe we should re-enable the defaults so that this becomes meaningful again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants