Refactor execution functions with proper error handling #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianGCalderon
force-pushed
the
remove-unwraps
branch
2 times, most recently
from
684bf06 to
da146b6
Compare
JulianGCalderon
force-pushed
the
remove-unwraps
branch
from
709b9a6 to
9b1b15c
Compare
JulianGCalderon
force-pushed
the
remove-unwraps
branch
from
9b1b15c to
9809bd6
Compare
JulianGCalderon
force-pushed
the
remove-unwraps
branch
from
ac6f3a7 to
65b6a7d
Compare
JulianGCalderon
requested review from
edg-l,
igaray,
azteca1998,
fmoletta,
pefontana and
gabrielbosio
as code owners
This was
linked to
issues
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99, #84, #18
Supersedes #19
This PR refactors the execution functions to make them easier to user, and adds proper error handling. I replaced the old functions with 2 new functions:
execute_transaction: Executes a single transaction with a clean state, fetching all needed information.fetch_transaction: Fetches all information needed to execute a transaction. Useful when you need to use a previous state, instead of a clean one. After callingfetch_transaction, you could just calltransaction.execute().The remaining changes on this PR are a side effect of the changes mentioned above.
The Github diff is not useful for reviewing the changes in
execution.rsas they have a lot of overlap. I'd suggest reviewing it with an external editor, as the whole file has been changed.Other Improvements
Given a transaction in block N, we used block N-1 for fetching the transaction contextual information, this would fail when trying to execute a Declare, as block N-1 didn't have the declared class. This PR changes this, so that block N is used to fetch the transaction information, while block N-1 is used as the starting execution state.
This changed the behaviour of some transactions, as the block context contains fields such as gas price. I had to adjust the tests to the new values, which I obtained by comparing with Cairo VM. Some transactions are now emitting more events than before, which I think that indicates that it's now working better.
The replay flag
--charge-feewas not being used. This PR fixes it.