Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] ForkChoiceUpdatedV3 hive tests #891

Closed
4 of 6 tasks
Arkenan opened this issue Oct 18, 2024 · 1 comment
Closed
4 of 6 tasks

[Tracking] ForkChoiceUpdatedV3 hive tests #891

Arkenan opened this issue Oct 18, 2024 · 1 comment

Comments

@Arkenan
Copy link
Collaborator

Arkenan commented Oct 18, 2024

This is a non comprehensive list of tests that should pass for us to consider we support Fork Choice updates up to the spec standards. Implementing the missing features does not eliminate the need for unit tests.

These are all in the Cancun suite.

ForkChoiceUpdated

  • Implement ForkChoiceUpdatedV2 #892
    • ForkchoiceUpdatedV3 Set Head to Shanghai Payload, Null Payload Attributes.
    • ForkchoiceUpdatedV3 To Request Shanghai Payload, Non-Null Beacon Root.
    • ForkchoiceUpdatedV3 Modifies Payload ID on Different Beacon Root.
    • ForkchoiceUpdatedV2 then ForkchoiceUpdatedV3 Valid Payload Building Requests

Reorgs

  • Engine NewPayload: latest valid hash should be respect to the requested branch #911

    • Invalid Missing Ancestor ReOrg, StateRoot, EmptyTxs=False, Invalid P1
    • Invalid Missing Ancestor ReOrg, StateRoot, EmptyTxs=True, Invalid P1
  • Remove Reorgs not implemented error in new payload v3 #893

    • Invalid Missing Ancestor ReOrg, StateRoot, EmptyTxs=False, Invalid P9
    • Invalid Missing Ancestor ReOrg, StateRoot, EmptyTxs=True, Invalid P9
    • Invalid Missing Ancestor ReOrg, StateRoot, EmptyTxs=False, Invalid P10
    • Invalid Missing Ancestor ReOrg, StateRoot, EmptyTxs=True, Invalid P10
  • Implement rudimentary syncing #894

  • Implement syncing

    • Invalid Missing Ancestor Syncing ReOrg, StateRoot, EmptyTxs=True, CanonicalReOrg=False, Invalid P9
    • Invalid Missing Ancestor Syncing ReOrg, StateRoot, EmptyTxs=False, CanonicalReOrg=False, Invalid P9
    • Invalid Missing Ancestor Syncing ReOrg, StateRoot, EmptyTxs=True, CanonicalReOrg=True, Invalid P9
    • Invalid Missing Ancestor Syncing ReOrg, StateRoot, EmptyTxs=False, CanonicalReOrg=True, Invalid P9
    • Invalid Missing Ancestor Syncing ReOrg, ReceiptsRoot, EmptyTxs=False, CanonicalReOrg=False, Invalid P8
    • Invalid Missing Ancestor Syncing ReOrg, ReceiptsRoot, EmptyTxs=False, CanonicalReOrg=True, Invalid P8
    • Invalid Missing Ancestor Syncing ReOrg, GasLimit, EmptyTxs=False, CanonicalReOrg=False, Invalid P8
    • Invalid Missing Ancestor Syncing ReOrg, GasLimit, EmptyTxs=False, CanonicalReOrg=True, Invalid P8
    • Invalid Missing Ancestor Syncing ReOrg, GasUsed, EmptyTxs=False, CanonicalReOrg=False, Invalid P8
    • Invalid Missing Ancestor Syncing ReOrg, GasUsed, EmptyTxs=False, CanonicalReOrg=True, Invalid P8
    • Invalid Missing Ancestor Syncing ReOrg, Timestamp, EmptyTxs=False, CanonicalReOrg=False, Invalid P8
    • Invalid Missing Ancestor Syncing ReOrg, Timestamp, EmptyTxs=False, CanonicalReOrg=True, Invalid P8
    • Invalid Missing Ancestor Syncing ReOrg, Incomplete Transactions, EmptyTxs=False, CanonicalReOrg=False, Invalid P9
    • Invalid Missing Ancestor Syncing ReOrg, Incomplete Transactions, EmptyTxs=False, CanonicalReOrg=True, Invalid P9
    • Invalid Missing Ancestor Syncing ReOrg, Transaction Signature, EmptyTxs=False, CanonicalReOrg=False, Invalid P9
    • Invalid Missing Ancestor Syncing ReOrg, Transaction Signature, EmptyTxs=False, CanonicalReOrg=True, Invalid P9
    • Invalid Missing Ancestor Syncing ReOrg, Transaction Nonce, EmptyTxs=False, CanonicalReOrg=False, Invalid P9
    • Invalid Missing Ancestor Syncing ReOrg, Transaction Nonce, EmptyTxs=False, CanonicalReOrg=True, Invalid P9
    • Invalid Missing Ancestor Syncing ReOrg, Transaction Gas, EmptyTxs=False, CanonicalReOrg=False, Invalid P9
    • Invalid Missing Ancestor Syncing ReOrg, Transaction Gas, EmptyTxs=False, CanonicalReOrg=True, Invalid P9
    • Invalid Missing Ancestor Syncing ReOrg, Transaction GasPrice, EmptyTxs=False, CanonicalReOrg=False, Invalid P9
    • Invalid Missing Ancestor Syncing ReOrg, Transaction GasPrice, EmptyTxs=False, CanonicalReOrg=True, Invalid P9
    • Invalid Missing Ancestor Syncing ReOrg, Transaction Value, EmptyTxs=False, CanonicalReOrg=False, Invalid P9
    • Invalid Missing Ancestor Syncing ReOrg, Transaction Value, EmptyTxs=False, CanonicalReOrg=True, Invalid P9
  • Bug: alternative payload does not contain the prevRandao opcode tx #895

    • Sidechain Reorg
@Arkenan Arkenan added this to the 2 - History & Reorgs milestone Oct 18, 2024
@mpaulucci mpaulucci pinned this issue Oct 18, 2024
@Arkenan
Copy link
Collaborator Author

Arkenan commented Nov 15, 2024

Closing this issue in favor of #1187 which is more general.

@Arkenan Arkenan closed this as completed Nov 15, 2024
@Arkenan Arkenan unpinned this issue Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant