Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1 P2P: avoid repeated GetPooledTransactions requests #1415

Open
Arkenan opened this issue Dec 5, 2024 · 0 comments
Open

L1 P2P: avoid repeated GetPooledTransactions requests #1415

Arkenan opened this issue Dec 5, 2024 · 0 comments

Comments

@Arkenan
Copy link
Collaborator

Arkenan commented Dec 5, 2024

Low priority. Right now when a PooledTransactionHashes message arrives to our node we immediately check which transactions we don't have and send a GetPooledTransactions message. There is a possible edge case where we might receive the same pooled transaction hash from multiple peers and perform the request twice. This is not high priority as it would not cause inconsistencies on our node, but it may occupy more bandwidth. It might be useful to keep track of which transactions we're already requesting so we don't request the same one multiple times.

@Arkenan Arkenan changed the title Avoid repeated GetPooledTransactions requests L1: avoid repeated GetPooledTransactions requests Dec 5, 2024
@Arkenan Arkenan changed the title L1: avoid repeated GetPooledTransactions requests L1 P2P: avoid repeated GetPooledTransactions requests Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant