From be61c69c3d60d837482c97ebc0e61d8c8da40c4a Mon Sep 17 00:00:00 2001 From: LeanSerra <46695152+LeanSerra@users.noreply.github.com> Date: Fri, 20 Dec 2024 12:54:31 -0300 Subject: [PATCH] chore(levm): ignore some json files we dont want to fix for now (#1551) **Motivation** We want to ignore some tests for now, we ignore them in the code so people don't try to fix them and waste time **Description** Add a list with the json files we want to ignore and skip them when parsing. --- cmd/ef_tests/levm/parser.rs | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/cmd/ef_tests/levm/parser.rs b/cmd/ef_tests/levm/parser.rs index 98943f114..d100c591f 100644 --- a/cmd/ef_tests/levm/parser.rs +++ b/cmd/ef_tests/levm/parser.rs @@ -20,6 +20,15 @@ pub enum EFTestParseError { FailedToParseTestFile(String), } +const IGNORED_TESTS: [&str; 6] = [ + "ValueOverflowParis.json", // Skip because of errors + "loopMul.json", // Skip because it takes too long to run + "dynamicAccountOverwriteEmpty_Paris.json", // Skip because it fails on REVM + "RevertInCreateInInitCreate2Paris.json", // Skip because it fails on REVM + "create2collisionStorageParis.json", // Skip because it fails on REVM + "InitCollisionParis.json", // Skip because it fails on REVM +]; + pub fn parse_ef_tests(opts: &EFTestRunnerOptions) -> Result, EFTestParseError> { let parsing_time = std::time::Instant::now(); let cargo_manifest_dir = std::path::PathBuf::from(env!("CARGO_MANIFEST_DIR")); @@ -87,11 +96,11 @@ pub fn parse_ef_test_dir( { continue; } - // Skip the ValueOverflowParis.json file because of errors, and loopMul.json because it takes too long to run. + // Skip ignored tests if test .path() .file_name() - .is_some_and(|name| name == "ValueOverflowParis.json" || name == "loopMul.json") + .is_some_and(|name| IGNORED_TESTS.contains(&name.to_str().unwrap_or(""))) { continue; }