Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend BlockExt and LibFuncHelper and consolidate it across all the codebase #862

Open
edg-l opened this issue Oct 17, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@edg-l
Copy link
Member

edg-l commented Oct 17, 2024

The BlockExt and LibFuncHelper are on the right track to simplify code. We need to apply the existing abstractions across the whole source code, and some extensions could help as well.

One noticeable source of repetition in Starknet libfuncs is the handling of return values: filling payload_ok and payload_err takes 70loc per function. This could be extracted to a helper function.

Other sources of verbosity include arithmetic comparisons and function calls (including the lookup for the pointer, the getelementptr call and then afterwards the call itself). All of that would be more brief with helpers.

@edg-l edg-l added the enhancement New feature or request label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant