fix: remove static lifetime for name str parameter requirement for constant getter #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eikix
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono and
pefontana
as code owners
fmoletta
previously approved these changes
Dec 21, 2023
Oppen
reviewed
Dec 21, 2023
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1523 +/- ##
==========================================
+ Coverage 94.76% 97.11% +2.34%
==========================================
Files 101 91 -10
Lines 38826 37248 -1578
==========================================
- Hits 36795 36172 -623
+ Misses 2031 1076 -955 ☔ View full report in Codecov by Sentry. |
Oppen
previously approved these changes
Dec 21, 2023
Eikix
force-pushed
the
fix/get_constant_from_var_name
branch
from
5789f5e to
a2a932e
Compare
Eikix
force-pushed
the
fix/get_constant_from_var_name
branch
from
a272b73 to
42db06f
Compare
Oppen
previously approved these changes
Dec 22, 2023
fmoletta
previously approved these changes
Dec 22, 2023
Oppen
previously approved these changes
Jan 22, 2024
fmoletta
previously approved these changes
Jan 22, 2024
|
Applying this patch should fix the linter: diff --git a/vm/src/hint_processor/builtin_hint_processor/math_utils.rs b/vm/src/hint_processor/builtin_hint_processor/math_utils.rs
index 68cb30fc1..bbe18b5d7 100644
--- a/vm/src/hint_processor/builtin_hint_processor/math_utils.rs
+++ b/vm/src/hint_processor/builtin_hint_processor/math_utils.rs
@@ -2085,7 +2085,7 @@ mod tests {
//Execute the hint
assert_matches!(
run_hint!(vm, ids_data, hint_code),
- Err(HintError::MissingConstant(bx)) if *bx == ADDR_BOUND.to_string()
+ Err(HintError::MissingConstant(bx)) if &*bx == ADDR_BOUND
);
}
@@ -2309,7 +2309,7 @@ mod tests {
//Execute the hint
assert_matches!(
run_hint!(vm, ids_data, hint_code),
- Err(HintError::MissingConstant(x)) if (*x) == "MAX_HIGH".to_string()
+ Err(HintError::MissingConstant(x)) if &*x == "MAX_HIGH"
);
}
diff --git a/vm/src/hint_processor/builtin_hint_processor/uint384.rs b/vm/src/hint_processor/builtin_hint_processor/uint384.rs
index 4e2bb4412..9f6646dd3 100644
--- a/vm/src/hint_processor/builtin_hint_processor/uint384.rs
+++ b/vm/src/hint_processor/builtin_hint_processor/uint384.rs
@@ -535,7 +535,7 @@ mod tests {
//Execute the hint
assert_matches!(
run_hint!(vm, ids_data, hint_code::ADD_NO_UINT384_CHECK),
- Err(HintError::MissingConstant(bx)) if *bx == "SHIFT".to_string()
+ Err(HintError::MissingConstant(bx)) if &*bx == "SHIFT"
);
} |
fmoletta
approved these changes
Jan 26, 2024
Oppen
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove static lifetime for name str parameter requirement for constant getter
Description
Hey!
I noticed
get_constant_from_var_namehas a different signature from other hint_utils helper functions, namely that it has a bound of static lifetime on the name parameter. I noticed it mainly comes from the error signatureHintError::MissingConstant.I changed the signature of
MissingConstantto match other errors: from Box<'static &str> to Box using the same util you use around the hint error codebase:var_name.to_string().into_boxed_str().In doing this, one no longer needs to have 'static strings for constant getting -> this will allow me in next PRs to have dynamic constant name getting, i.e., in garaga there are constant limbs of Prime P of the BN Curve.
And depending on
N_LIMBS, we'll getP_i.Let me know if this works!
Resolves: #1522
Description of the pull request changes and motivation.
Checklist