Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

links has become forms #6

Open
rwb27 opened this issue Apr 19, 2021 · 1 comment
Open

links has become forms #6

rwb27 opened this issue Apr 19, 2021 · 1 comment

Comments

@rwb27
Copy link
Contributor

rwb27 commented Apr 19, 2021

Currently, td_parser fails when looking at a new LabThing using the current version of the Python server. I believe this is because it's expecting to find links in a list called links for each affordance, but they are actually in a list called forms. This is the same API change addressed by #4, in a different place in the client code.
@rwb27
Copy link
Contributor Author

rwb27 commented Apr 19, 2021

This could be fixed by changing line 14 of affordances.py to use forms instead of links but of course that's not backwards-compatible. Doing so with a fallback to links would work, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rwb27