Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset cancel event #2

Open
rwb27 opened this issue Jan 10, 2024 · 1 comment
Open

Reset cancel event #2

rwb27 opened this issue Jan 10, 2024 · 1 comment

Comments

@rwb27
Copy link
Collaborator

rwb27 commented Jan 10, 2024

I think it wouldl be a good idea to reset the cancel event after aborting a move and raising an exception. This would allow, for example, an action to move back to the starting position when it's cancelled (without using the block_cancellation argument, which I feel should be used sparingly).

@rwb27
Copy link
Collaborator Author

rwb27 commented Dec 20, 2024

This might be better done by the calling code - i.e. when you handle an InvocationCancelledError, you should reset the event?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant