Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve move cancellation #1

Open
rwb27 opened this issue Jan 4, 2024 · 0 comments
Open

Improve move cancellation #1

rwb27 opened this issue Jan 4, 2024 · 0 comments

Comments

@rwb27
Copy link
Collaborator

rwb27 commented Jan 4, 2024

Currently, moves >5000 steps are done non-blocking. This is slightly inelegant, because it involves quite a few queries:

  • Disable blocking moves
  • Start the move
  • LOOP
    • Query if we're moving
    • Wait
  • Re-enable blocking moves

There's also jitter that will come from the Python code waiting in between polls.

A much more elegant way would be to add a timeout to wait_until_stopped (would require firmware update) so that we can long-poll it. I'd be pretty confident that this wouldn't affect the timings noticeably, so we could then make moves non-blocking by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant