feat:add vlogs server. #5343
Open
feat:add vlogs server. #5343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat:add vlogs server feat:add vlogs server feat:add vlogs server feat:add vlogs server
bxy4543
reviewed
Jan 13, 2025
| @@ -0,0 +1,55 @@ | |||
| IMG ?= ghcr.io/labring/sealos-launchpad-service:latest | |||
|
|
||
| .PHONY: docker-build | ||
| docker-build: build | ||
| mv bin/manager bin/service-launchpad-${TARGETARCH} |
| 1. Build and push your image to the location specified by `IMG`: | ||
|
|
||
| ```sh | ||
| make docker-build docker-push IMG=<some-registry>/sealos-cloud-database-monitor:tag |
| env: | ||
| - name: VM_SERVICE_HOST | ||
| value: http://vmsingle-victoria-metrics-k8s-stack.vm.svc:8429 | ||
| image: ghcr.io/labring/sealos-launchpad-service:latest |
| kind: Service | ||
| metadata: | ||
| labels: | ||
| app: launchpad-vlogs |
| if config, err := url.PathUnescape(kubeConfig); err == nil { | ||
| kubeConfig = config | ||
| } else { | ||
| return "", "", "", err |
There was a problem hiding this comment.
return with fmt.Errorf("failed to PathUnescape : %s", err)
For different errors in the same method, please use format to wrap different error messages.
| vlogsReq := &api.VlogsRequest{} | ||
| err := json.NewDecoder(req.Body).Decode(&vlogsReq) | ||
| if err != nil { | ||
| return "", "", "", errors.New("invalid JSON data,decode error") |
There was a problem hiding this comment.
The original error message is not included, replace with fmt.Errorf and include the original err information.
service/vlogs/server/server.go
Outdated
| return stream + generateCommonQuery(req) + builder.String() + generateDropQuery() + generateNumberQuery(req), nil | ||
| } | ||
|
|
||
| func generateStreamQuery(req *api.VlogsRequest) (string, error) { |
There was a problem hiding this comment.
Why is there no error return, but the return parameter needs to contain error?
service/vlogs/server/server.go
Outdated
| return builder.String() + stream + generateCommonQuery(req) + generateDropQuery() + generateNumberQuery(req), nil | ||
| } | ||
|
|
||
| func generateJsonQuery(req *api.VlogsRequest) (string, error) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.