Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong text color with jupytelab 4 in darkmode #284

Open
PicoCentauri opened this issue May 16, 2023 · 1 comment
Open

Wrong text color with jupytelab 4 in darkmode #284

PicoCentauri opened this issue May 16, 2023 · 1 comment
Labels
component-jupyter Issues related to the Jupyter widget

Comments

@PicoCentauri
Copy link

With JupyterLab in the dark theme the text of the pop up panels is white even though the background color is white as well (see screenshot below). When using the light theme the text is correctly displayed in black.

I suggest that the background color of the pop ups should be changed to black when jupyter is used with the dark theme.

Screenshot 2023-05-16 at 11 22 25
@PicoCentauri PicoCentauri added the component-jupyter Issues related to the Jupyter widget label May 16, 2023
@Luthaf
Copy link
Contributor

Luthaf commented May 16, 2023

So what I think is happening here is that we are inheriting the text color from the root HTML, and jupyter changes that to white in dark mode.

The simplest fix would be to make sure we explicitly set text color to black/dark grey instead of inheriting the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-jupyter Issues related to the Jupyter widget
Projects
None yet
Development

No branches or pull requests

2 participants