Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using some smart way to implement the async programing in the Plugin::start #98

Open
vincenzopalazzo opened this issue May 11, 2023 · 0 comments
Open

using some smart way to implement the async programing in the Plugin::start #98

vincenzopalazzo opened this issue May 11, 2023 · 0 comments
Labels
🐛 bug Something isn't working plugin API related to cln plugin API 🪀 enhancement New feature or request

Comments

@vincenzopalazzo
Copy link
Collaborator

I think this part of our codebase https://github.com/laanwj/cln4rust/blob/master/plugin/src/plugin.rs#L260-L284

is causing problems like the one coffee-tools/folgore#25

We should use a library like https://github.com/cloudhead/popol or https://github.com/tokio-rs/mio to await new events
@vincenzopalazzo vincenzopalazzo added 🐛 bug Something isn't working 🪀 enhancement New feature or request plugin API related to cln plugin API labels May 11, 2023
vincenzopalazzo added a commit that referenced this issue Dec 25, 2023
@vincenzopalazzo
feat(plugin): add async io for the plugin
4f560e1 
Adding the support of the async io for reading to the
std io.

Link: #98
Signed-off-by: Vincenzo Palazzo <[email protected]>
@vincenzopalazzo vincenzopalazzo mentioned this issue Dec 25, 2023
Closed
vincenzopalazzo added a commit that referenced this issue Dec 25, 2023
@vincenzopalazzo
feat(plugin): add async io for the plugin
90f17b3 
Adding the support of the async io for reading to the
std io.

Link: #98
Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo added a commit that referenced this issue Mar 23, 2024
@vincenzopalazzo
feat(plugin): add async io for the plugin
4ee4378 
Adding the support of the async io for reading to the
std io.

Link: #98
Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo added a commit that referenced this issue Mar 24, 2024
@vincenzopalazzo
feat(plugin): add async io for the plugin
02271f3 
Adding the support of the async io for reading to the
std io.

Link: #98
Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo added a commit that referenced this issue Mar 24, 2024
@vincenzopalazzo
feat(plugin): add async io for the plugin
1c04dbe 
Adding the support of the async io for reading to the
std io.

Link: #98
Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo added a commit that referenced this issue Mar 24, 2024
@vincenzopalazzo
feat(plugin): add async io for the plugin
0fa3096 
Adding the support of the async io for reading to the
std io.

Link: #98
Signed-off-by: Vincenzo Palazzo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working plugin API related to cln plugin API 🪀 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(plugin): add async io for the plugin laanwj/cln4rust
1 participant
@vincenzopalazzo