Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The app crash on the last beta #225

Closed
yotam20 opened this issue Jan 10, 2024 · 17 comments · Fixed by #231
Closed

The app crash on the last beta #225

yotam20 opened this issue Jan 10, 2024 · 17 comments · Fixed by #231
Assignees
Labels
bug Something isn't working

Comments

@yotam20
Copy link

yotam20 commented Jan 10, 2024

  • Device: pixel 6
  • OS: AP11.231215.007
@Demonic16
Copy link

Demonic16 commented Jan 10, 2024

Same to me. Crashes only when Shizuku is running. If Shizuku is stopped then Pixel IMS launches but obviously can't do anything.
Pixel 7 Pro, Android QPR2 Beta 3.

@iKirby
Copy link

iKirby commented Jan 11, 2024

EDIT: Please don't quote reply this long comment, it will make this thread a mess for other people to read. You can quote one of the lines or use @ to mention people.

This is because in the latest beta the following method changed. They added a third parameter which is a boolean.

List<SubscriptionInfo> getActiveSubscriptionInfoList(String str, String str2, boolean z) throws RemoteException;

The source code of beta versions won't be released until it reaches stable. There is no documentation and I don't know what the boolean means. EDIT: the third parameter is named isForAllProfiles, probably user profiles?

I haven't used hidden apis in Android Studio. So I modified Pixel IMS using APKTool.

The only file I modified is CarrierModer.smali, starting at line 310.

const/4 v1, 0x0

.line 81
invoke-interface {v0, p0, p0, v1}, Lcom/android/internal/telephony/ISub;->getActiveSubscriptionInfoList(Ljava/lang/String;Ljava/lang/String;Z)Ljava/util/List;

Passing false for the third parameter works (at least for now).

If you need it you can download it below. GitHub doesn't allow uploading apk files so I put it in a zip archive.

pixelims_zipaligned.zip

or get it on Google Drive: https://drive.google.com/file/d/1zqVShKvd9adwXSFVB1yVh81jjcX4dagB/view?usp=sharing

@Aduhelm
Copy link

Aduhelm commented Jan 11, 2024

This is because in the latest beta the following method changed. They added a third parameter which is a boolean.

List<SubscriptionInfo> getActiveSubscriptionInfoList(String str, String str2, boolean z) throws RemoteException;

The source code of beta versions won't be released until it reaches stable. There is no documentation and I don't know what the boolean means.

I haven't used hidden apis in Android Studio. So I modified Pixel IMS using APKTool.

The only file I modified is CarrierModer.smali, starting at line 310.

const/4 v1, 0x0

.line 81
invoke-interface {v0, p0, p0, v1}, Lcom/android/internal/telephony/ISub;->getActiveSubscriptionInfoList(Ljava/lang/String;Ljava/lang/String;Z)Ljava/util/List;

Passing false for the third parameter works (at least for now).

If you need it you can download it below. GitHub doesn't allow uploading apk files so I put it in a zip archive.

pixelims_zipaligned.zip

or get it on Google Drive: https://drive.google.com/file/d/1zqVShKvd9adwXSFVB1yVh81jjcX4dagB/view?usp=sharing

IT works

@yotam20
Copy link
Author

yotam20 commented Jan 11, 2024

It works for me thanks

@ofir29200
Copy link

ofir29200 commented Jan 11, 2024

This is because in the latest beta the following method changed. They added a third parameter which is a boolean.

List<SubscriptionInfo> getActiveSubscriptionInfoList(String str, String str2, boolean z) throws RemoteException;

The source code of beta versions won't be released until it reaches stable. There is no documentation and I don't know what the boolean means. EDIT: the third parameter is named isForAllProfiles, probably user profiles?

I haven't used hidden apis in Android Studio. So I modified Pixel IMS using APKTool.

The only file I modified is CarrierModer.smali, starting at line 310.

const/4 v1, 0x0

.line 81
invoke-interface {v0, p0, p0, v1}, Lcom/android/internal/telephony/ISub;->getActiveSubscriptionInfoList(Ljava/lang/String;Ljava/lang/String;Z)Ljava/util/List;

Passing false for the third parameter works (at least for now).

If you need it you can download it below. GitHub doesn't allow uploading apk files so I put it in a zip archive.

pixelims_zipaligned.zip

or get it on Google Drive: https://drive.google.com/file/d/1zqVShKvd9adwXSFVB1yVh81jjcX4dagB/view?usp=sharing

It doesn't work for me on my pixel 6 pro.
It can see that shizuku is running, but it thinks it doesn't have permission, but in shizuku I can see that it does have permission

Screenshot_20240111-072135.png

Screenshot_20240111-072129.png

@iKirby
Copy link

iKirby commented Jan 11, 2024

@ofir29200 Could you please check if you have the latest version of Shizuku installed (v13.5.3 as of now)? I did just modify the two lines of code I've posted, that shouldn't affect other parts of the app.

@hsoc
Copy link

hsoc commented Jan 11, 2024

This is because in the latest beta the following method changed. They added a third parameter which is a boolean.

List<SubscriptionInfo> getActiveSubscriptionInfoList(String str, String str2, boolean z) throws RemoteException;

The source code of beta versions won't be released until it reaches stable. There is no documentation and I don't know what the boolean means. EDIT: the third parameter is named isForAllProfiles, probably user profiles?

I haven't used hidden apis in Android Studio. So I modified Pixel IMS using APKTool.

The only file I modified is CarrierModer.smali, starting at line 310.

const/4 v1, 0x0

.line 81
invoke-interface {v0, p0, p0, v1}, Lcom/android/internal/telephony/ISub;->getActiveSubscriptionInfoList(Ljava/lang/String;Ljava/lang/String;Z)Ljava/util/List;

Passing false for the third parameter works (at least for now).

If you need it you can download it below. GitHub doesn't allow uploading apk files so I put it in a zip archive.

pixelims_zipaligned.zip

or get it on Google Drive: https://drive.google.com/file/d/1zqVShKvd9adwXSFVB1yVh81jjcX4dagB/view?usp=sharing

It works. Thank you

@ofir29200
Copy link

@ofir29200 Could you please check if you have the latest version of Shizuku installed (v13.5.3 as of now)? I did just modify the two lines of code I've posted, that shouldn't affect other parts of the app.

i have Shizuku version 13.5.3.r1036.fff3f87

@iKirby
Copy link

iKirby commented Jan 11, 2024

@ofir29200 Please try restarting the app after granting permission. If it's still not working, then I don't know why. I can't reproduce it on both my phones (one with my modified version of Pixel IMS and one with the original version).

@ofir29200
Copy link

@ofir29200 Please try restarting the app after granting permission. If it's still not working, then I don't know why. I can't reproduce it on both my phones (one with my modified version of Pixel IMS and one with the original version).

i already tried to restart it. i even tried to clear all of the data of the app, and even reinstall the app, and its still the same....

@dtaluthge
Copy link

It works on pixel 6 pro. Thanks for the help.

@weigesxu
Copy link

Device: pixel 7
System: AP11.231215.007
Shizuku:13.5.3.r1036

Even after using a modified version of the program, it still crashes and cannot enter pixel ims normally.

@morhimi
Copy link

morhimi commented Jan 15, 2024

Device: pixel 7 System: AP11.231215.007 Shizuku:13.5.3.r1036

Even after using a modified version of the program, it still crashes and cannot enter pixel ims normally.

are you sure you are using the modified version?
you need to uninstall the original version prior to installing this modified version since they don't have the same signature

@vard0ger
Copy link

With modified version all work fine.

  • Clear all data and remove old version.
  • Install mod version.
  • Profit.

Px6 14 (AP11.231215.007)

@morhimi
Copy link

morhimi commented Jan 15, 2024

@kyujin-cho do you plan to release a new version?

@kyujin-cho
Copy link
Owner

@morhimi Eh... I acknowledged what's the problem. But for now, as @iKirby mentioned - on current way of implementation, until we see the official release of android software (along with published source code) we have not much things to do. Let me see if there's a workaround.

@kyujin-cho kyujin-cho added the bug Something isn't working label Jan 20, 2024
@kyujin-cho kyujin-cho self-assigned this Jan 20, 2024
@kyujin-cho
Copy link
Owner

Should be resolved by #231.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.